linux-kernel - Re: [PATCH 22/24] mtd: block2mtd: factor the early block device open logic into a helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230523113236.7003c303@xps-13>
Date:   Tue, 23 May 2023 11:32:36 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Mike Snitzer <snitzer@...nel.org>,
        Joern Engel <joern@...ybastard.org>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Pavel Machek <pavel@....cz>, dm-devel@...hat.com,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 22/24] mtd: block2mtd: factor the early block device
 open logic into a helper

Hi Christoph,

hch@....de wrote on Tue, 23 May 2023 09:45:33 +0200:

> Simply add_device a bit by splitting out the cumbersome early boot logic

I guess you meant "Simplify..."

Otherwise lgtm so,

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

> into a separate helper.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  drivers/mtd/devices/block2mtd.c | 53 +++++++++++++++++++--------------
>  1 file changed, 30 insertions(+), 23 deletions(-)
> 

Thanks,
Miquèl