linux-kernel - Re: [PATCH v8 3/6] ksm: add ksm zero pages for each process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a38e04a-df69-5c5d-5631-152b662db7a7@redhat.com>
Date:   Tue, 23 May 2023 11:55:43 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Yang Yang <yang.yang29@....com.cn>, akpm@...ux-foundation.org
Cc:     imbrenda@...ux.ibm.com, jiang.xuexin@....com.cn,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        ran.xiaokai@....com.cn, xu.xin.sc@...il.com, xu.xin16@....com.cn
Subject: Re: [PATCH v8 3/6] ksm: add ksm zero pages for each process

On 22.05.23 12:53, Yang Yang wrote:
> From: xu xin <xu.xin16@....com.cn>
> 
> As the number of ksm zero pages is not included in ksm_merging_pages per
> process when enabling use_zero_pages, it's unclear of how many actual
> pages are merged by KSM. To let users accurately estimate their memory
> demands when unsharing KSM zero-pages, it's necessary to show KSM zero-
> pages per process. In addition, it help users to know the actual KSM
> profit because KSM-placed zero pages are also benefit from KSM.
> 
> since unsharing zero pages placed by KSM accurately is achieved, then
> tracking empty pages merging and unmerging is not a difficult thing any
> longer.
> 
> Since we already have /proc/<pid>/ksm_stat, just add the information of
> 'ksm_zero_pages' in it.
> 
> Signed-off-by: xu xin <xu.xin16@....com.cn>
> Cc: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Xuexin Jiang <jiang.xuexin@....com.cn>
> Cc: Xiaokai Ran <ran.xiaokai@....com.cn>
> Cc: Yang Yang <yang.yang29@....com.cn>
> ---


LGTM. [inlining inc_ksm_zero_pages() and avoiding explicit 
dec_ksm_zero_pages() as noted on patch #2 ]

-- 
Thanks,

David / dhildenb