linux-kernel - Re: [PATCH] platform/x86: lenovo-yogabook: add I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c27655d4-a679-0a62-54db-494601f40f7d@redhat.com>
Date:   Tue, 23 May 2023 13:09:18 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Arnd Bergmann <arnd@...nel.org>, Mark Gross <markgross@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: lenovo-yogabook: add I2C dependency

Hi Arnd,

On 5/19/23 10:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The added platform_driver support fails to link when I2C core support is
> not rechable:
> 
> x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
> lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'
> 
> Add a Kconfig dependency to enforce a working configuration.
> 
> Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thank you I have pushed this to pdx86/for-next now.

Regards,

Hans



> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9fe974d5f645..63637ea99c2f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -125,6 +125,7 @@ config YOGABOOK
>  	tristate "Lenovo Yoga Book tablet key driver"
>  	depends on ACPI_WMI
>  	depends on INPUT
> +	depends on I2C
>  	select LEDS_CLASS
>  	select NEW_LEDS
>  	help