linux-kernel - Re: [PATCH v4 8/8] sysctl: Remove register_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 May 2023 14:57:25 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Joel Granados <j.granados@...sung.com>
Cc:     mcgrof@...nel.org, Kees Cook <keescook@...omium.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Iurii Zaikin <yzaikin@...gle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [PATCH v4 8/8] sysctl: Remove register_sysctl_table

On Tue, May 23, 2023 at 02:22:20PM +0200, Joel Granados wrote:
> This is part of the general push to deprecate register_sysctl_paths and
> register_sysctl_table. After removing all the calling functions, we
> remove both the register_sysctl_table function and the documentation
> check that appeared in check-sysctl-docs awk script.
> 
> We save 595 bytes with this change:
> 
> ./scripts/bloat-o-meter vmlinux.1.refactor-base-paths vmlinux.2.remove-sysctl-table
> add/remove: 2/8 grow/shrink: 1/0 up/down: 1154/-1749 (-595)
> Function                                     old     new   delta
> count_subheaders                               -     983    +983
> unregister_sysctl_table                       29     184    +155
> __pfx_count_subheaders                         -      16     +16
> __pfx_unregister_sysctl_table.part            16       -     -16
> __pfx_register_leaf_sysctl_tables.constprop   16       -     -16
> __pfx_count_subheaders.part                   16       -     -16
> __pfx___register_sysctl_base                  16       -     -16
> unregister_sysctl_table.part                 136       -    -136
> __register_sysctl_base                       478       -    -478
> register_leaf_sysctl_tables.constprop        524       -    -524
> count_subheaders.part                        547       -    -547
> Total: Before=21257652, After=21257057, chg -0.00%
> 
> Signed-off-by: Joel Granados <j.granados@...sung.com>
> [mcgrof: remove register_leaf_sysctl_tables and append_path too and
>  add bloat-o-meter stats]
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
> ---

Acked-by: Christian Brauner <brauner@...nel.org>