linux-kernel - Re: [PATCH] x86/pci/xen: populate MSI sysfs entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0f7cf97-f7ea-83f2-3a9c-f77f82dfb689@suse.com>
Date:   Wed, 24 May 2023 17:47:44 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Maximilian Heyne <mheyne@...zon.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, xen-devel@...ts.xenproject.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Ashok Raj <ashok.raj@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marc Zyngier <maz@...nel.org>,
        "Ahmed S. Darwish" <darwi@...utronix.de>,
        Kevin Tian <kevin.tian@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] x86/pci/xen: populate MSI sysfs entries

On 24.05.23 17:43, Maximilian Heyne wrote:
> On Wed, May 03, 2023 at 01:16:53PM +0000, Maximilian Heyne wrote:
>> Commit bf5e758f02fc ("genirq/msi: Simplify sysfs handling") reworked the
>> creation of sysfs entries for MSI IRQs. The creation used to be in
>> msi_domain_alloc_irqs_descs_locked after calling ops->domain_alloc_irqs.
>> Then it moved into __msi_domain_alloc_irqs which is an implementation of
>> domain_alloc_irqs. However, Xen comes with the only other implementation
>> of domain_alloc_irqs and hence doesn't run the sysfs population code
>> anymore.
>>
>> Commit 6c796996ee70 ("x86/pci/xen: Fixup fallout from the PCI/MSI
>> overhaul") set the flag MSI_FLAG_DEV_SYSFS for the xen msi_domain_info
>> but that doesn't actually have an effect because Xen uses it's own
>> domain_alloc_irqs implementation.
>>
>> Fix this by making use of the fallback functions for sysfs population.
>>
>> Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling")
>> Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
> 
> 
> Any other feedback on this one? This is definitely a bug but I understand that
> there might be different ways to fix it.

I'd be happy to take the patch via the Xen tree, but I think x86 maintainers
should at least ack that.


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)