linux-kernel - Re: [PATCH 1/2] tpm: tis_i2c: Limit read bursts to I2C_SMBUS_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0b56100e7a8cdea42972637d2c32fce367a8286.camel@kernel.org>
Date:   Wed, 24 May 2023 19:03:43 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     "A. Sverdlin" <alexander.sverdlin@...mens.com>,
        linux-integrity@...r.kernel.org
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-kernel@...r.kernel.org,
        Alexander Steffen <Alexander.Steffen@...ineon.com>,
        Michael Haener <michael.haener@...mens.com>
Subject: Re: [PATCH 1/2] tpm: tis_i2c: Limit read bursts to
 I2C_SMBUS_BLOCK_MAX (32) bytes

On Wed, 2023-05-24 at 17:40 +0200, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> 
> Underlying I2C bus drivers not always support longer transfers and
> imx-lpi2c for instance doesn't. SLB 9673 offers 427-bytes packets.
> 
> Visible symptoms are:
> 
> tpm tpm0: Error left over data
> tpm tpm0: tpm_transmit: tpm_recv: error -5
> tpm_tis_i2c: probe of 1-002e failed with error -5
> 
> Fixes: bbc23a07b072 ("tpm: Add tpm_tis_i2c backend for tpm_tis_core")
> Tested-by: Michael Haener <michael.haener@...mens.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko