linux-kernel - RE: [EXTERNAL] Re: [PATCH 1/2] x86/Kconfig: Allow CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 May 2023 16:23:03 +0000
From:   Saurabh Singh Sengar <ssengar@...rosoft.com>
To:     Dave Hansen <dave.hansen@...el.com>,
        Saurabh Sengar <ssengar@...ux.microsoft.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH 1/2] x86/Kconfig: Allow CONFIG_X86_MPPARSE
 disable for OF platforms



> -----Original Message-----
> From: Dave Hansen <dave.hansen@...el.com>
> Sent: Tuesday, May 23, 2023 11:23 PM
> To: Saurabh Sengar <ssengar@...ux.microsoft.com>; tglx@...utronix.de;
> mingo@...hat.com; bp@...en8.de; dave.hansen@...ux.intel.com;
> x86@...nel.org; hpa@...or.com; KY Srinivasan <kys@...rosoft.com>;
> Haiyang Zhang <haiyangz@...rosoft.com>; wei.liu@...nel.org; Dexuan Cui
> <decui@...rosoft.com>; Michael Kelley (LINUX) <mikelley@...rosoft.com>;
> linux-kernel@...r.kernel.org; linux-hyperv@...r.kernel.org
> Cc: Saurabh Singh Sengar <ssengar@...rosoft.com>
> Subject: [EXTERNAL] Re: [PATCH 1/2] x86/Kconfig: Allow
> CONFIG_X86_MPPARSE disable for OF platforms
> 
> On 5/11/23 07:54, Saurabh Sengar wrote:
> > X86_MPPARSE is only selectable when ACPI is enabled. However, on
> > Devicetree platforms where ACPI is disabled, it is always enabled.
> > Allow X86_MPPARSE to be selected by OF platforms as well.
> 
> I'm finding this changelog really hard to read.
> 
> In Kconfig, you can "select FOO".  But in this changelog, it means something
> different.  I think "selectable" here means that there's a user prompt for the
> option.
> 
> Could you please rephrase this to be less confusing?

Thanks for your review. Currently, in the absence of ACPI, it is impossible to
disable X86_MPPARSE. In the case of ACPI being enabled, one has the
option to either enable or disable X86_MPARSE. My intention is to permit
X86_MPPARSE=n for OF platforms where ACPI=n. To describe the capability
of choosing any desired value for MPPARSE, I used the term 'selectable.'
Perhaps 'configurable' would be a more appropriate word in this context?
I can fix this and include it in V2.

> 
> This is also one of those patches where I wonder: Why do _you_ care about
> this?  Are you just trying to be nice?  Is this intended as some kind of cleanup?


It solves an issue for Hyper-V VBS setup, please refer to the 2/2 of this patch
series.

Regards,
Saurabh