linux-kernel - Re: [PATCH v2] fscrypt: Replace 1-element array with flexible array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230524025528.GA1076@sol.localdomain>
Date:   Tue, 23 May 2023 19:55:28 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        linux-fscrypt@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] fscrypt: Replace 1-element array with flexible array

On Tue, May 23, 2023 at 09:55:02AM -0700, Kees Cook wrote:
> 1-element arrays are deprecated and are being replaced with C99
> flexible arrays[1].
> 
> As sizes were being calculated with the extra byte intentionally,
> propagate the difference so there is no change in binary output.
> 
> [1] https://github.com/KSPP/linux/issues/79
> 
> Cc: Eric Biggers <ebiggers@...nel.org>
> Cc: "Theodore Y. Ts'o" <tytso@....edu>
> Cc: Jaegeuk Kim <jaegeuk@...nel.org>
> Cc: Gustavo A. R. Silva <gustavoars@...nel.org>
> Cc: linux-fscrypt@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> v2: update commit log to avoid mentioning "len" member.
> v1: https://lore.kernel.org/lkml/20230522213924.never.119-kees@kernel.org/
> ---
>  fs/crypto/fscrypt_private.h |  2 +-
>  fs/crypto/hooks.c           | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)

Thanks, applied to
https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next

- Eric