linux-kernel - Re: [PATCH 3/4] fbdev: imsttfb: Move a variable assignment for an error code in imsttfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a4b406f1-5395-1187-a27a-26fc4a5a00c5@gmx.de>
Date:   Wed, 24 May 2023 20:11:31 +0200
From:   Helge Deller <deller@....de>
To:     Markus Elfring <Markus.Elfring@....de>,
        kernel-janitors@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Javier Martinez Canillas <javierm@...hat.com>,
        Michal Koutný <mkoutny@...e.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Zheng Wang <zyytlz.wz@....com>
Cc:     LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr,
        1395428693sheep@...il.com, alex000young@...il.com,
        hackerzheng666@...il.com
Subject: Re: [PATCH 3/4] fbdev: imsttfb: Move a variable assignment for an
 error code in imsttfb_probe()

On 5/23/23 19:42, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 23 May 2023 18:30:26 +0200
>
> The value “-ENOMEM” was assigned to the variable “ret”
> at the beginning.
> Move this statement directly before the first ioremap() call.

Please do not move such variables without real need.
It makes backporting (of this and maybe follow-up patches) much more
complicated and the compiler will optimize it anyway.

Thanks!
Helge

>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>   drivers/video/fbdev/imsttfb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c
> index 6490f544f8eb..90c72428e8d7 100644
> --- a/drivers/video/fbdev/imsttfb.c
> +++ b/drivers/video/fbdev/imsttfb.c
> @@ -1484,7 +1484,6 @@ static int imsttfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	ret = aperture_remove_conflicting_pci_devices(pdev, "imsttfb");
>   	if (ret)
>   		return ret;
> -	ret = -ENOMEM;
>
>   	dp = pci_device_to_OF_node(pdev);
>   	if(dp)
> @@ -1525,6 +1524,7 @@ static int imsttfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	}
>
>   	info->fix.smem_start = addr;
> +	ret = -ENOMEM;
>   	info->screen_base = (__u8 *)ioremap(addr, par->ramdac == IBM ?
>   					    0x400000 : 0x800000);
>   	if (!info->screen_base)
> --
> 2.40.1
>