linux-kernel - Re: [PATCH 2/3] clk: qcom: gpucc-sm8550: Add support for graphics clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c8e76ea-75c9-4821-e962-b15505b82f85@quicinc.com>
Date:   Wed, 24 May 2023 23:47:49 +0530
From:   Jagadeesh Kona <quic_jkona@...cinc.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        "Michael Turquette" <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Satya Priya Kakitapalli <quic_skakitap@...cinc.com>,
        Taniya Das <quic_tdas@...cinc.com>,
        <quic_imrashai@...cinc.com>, <quic_ajipan@...cinc.com>
Subject: Re: [PATCH 2/3] clk: qcom: gpucc-sm8550: Add support for graphics
 clock controller

Hi Dmitry,

Thanks for your review!

On 5/20/2023 4:35 AM, Dmitry Baryshkov wrote:
> On 20/05/2023 00:36, Jagadeesh Kona wrote:
>> Add support for gpucc driver on SM8550, which provides clocks for the
>> graphics subsystem.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@...cinc.com>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
> 
> Jagadeesh, if you are submitting a patch, your sign-off should be the 
> last one. If Taniya participated in development of the driver, you might 
> want to add the "Co-Developed-by" tag in addition to existing ones.
> 
Yes, will take care of this in next series.

>> ---
>>   drivers/clk/qcom/Kconfig        |   8 +
>>   drivers/clk/qcom/Makefile       |   1 +
>>   drivers/clk/qcom/gpucc-sm8550.c | 609 ++++++++++++++++++++++++++++++++
>>   3 files changed, 618 insertions(+)
>>   create mode 100644 drivers/clk/qcom/gpucc-sm8550.c
>>
> 
> [skipped]
> 
>> +static int __init gpu_cc_sm8550_init(void)
>> +{
>> +    return platform_driver_register(&gpu_cc_sm8550_driver);
>> +}
>> +subsys_initcall(gpu_cc_sm8550_init);
> 
> module_device_driver
> 
We need to evaluate if module_init_call works for all our usecases,
we will revisit and post a cleanup patch once we conclude module_init is 
sufficient for all our usecases.

>> +
>> +static void __exit gpu_cc_sm8550_exit(void)
>> +{
>> +    platform_driver_unregister(&gpu_cc_sm8550_driver);
>> +}
>> +module_exit(gpu_cc_sm8550_exit);
>> +
>> +MODULE_DESCRIPTION("QTI GPU_CC SM8550 Driver");
>> +MODULE_LICENSE("GPL");
> 

Thanks & Regards,
Jagadeesh