linux-kernel - Re: [PATCH v2] drm/amd/display: enable more strict compile checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fefc712-913a-a391-bc7b-c0c75eff1c3d@amd.com>
Date:   Wed, 24 May 2023 15:45:57 -0400
From:   Felix Kuehling <felix.kuehling@....com>
To:     "Russell, Kent" <Kent.Russell@....com>,
        "Ho, Kenny" <Kenny.Ho@....com>,
        Alex Deucher <alexdeucher@...il.com>,
        "Mahfooz, Hamza" <Hamza.Mahfooz@....com>
Cc:     "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        Daniel Vetter <daniel@...ll.ch>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        David Airlie <airlied@...il.com>,
        "Koenig, Christian" <Christian.Koenig@....com>
Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks

Sure, I think we tried enabling warnings as errors before and had to 
revert it because of weird compiler quirks or the variety of compiler 
versions that need to be supported.

Alex, are you planning to upstream this, or is this only to enforce more 
internal discipline about not ignoring warnings?

Regards,
   Felix


On 2023-05-24 15:41, Russell, Kent wrote:
>
> [AMD Official Use Only - General]
>
>
> (Adding Felix in CC)
>
> I’m a fan of adding it to KFD as well. Felix, can you foresee any 
> issues here?
>
> Kent
>
> *From:* amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> *On Behalf Of 
> *Ho, Kenny
> *Sent:* Wednesday, May 24, 2023 3:23 PM
> *To:* Alex Deucher <alexdeucher@...il.com>; Mahfooz, Hamza 
> <Hamza.Mahfooz@....com>
> *Cc:* Li, Sun peng (Leo) <Sunpeng.Li@....com>; Wentland, Harry 
> <Harry.Wentland@....com>; Pan, Xinhui <Xinhui.Pan@....com>; Siqueira, 
> Rodrigo <Rodrigo.Siqueira@....com>; linux-kernel@...r.kernel.org; 
> dri-devel@...ts.freedesktop.org; amd-gfx@...ts.freedesktop.org; Daniel 
> Vetter <daniel@...ll.ch>; Deucher, Alexander 
> <Alexander.Deucher@....com>; David Airlie <airlied@...il.com>; Koenig, 
> Christian <Christian.Koenig@....com>
> *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile 
> checks
>
> [AMD Official Use Only - General]
>
> [AMD Official Use Only - General]
>
> (+ Felix)
>
> Should we do the same for other modules under amd (amdkfd)?  I was 
> going to enable full kernel werror in the kconfig used by my CI but 
> this is probably better.
>
> Kenny
>
> ------------------------------------------------------------------------
>
> *From:*Alex Deucher <alexdeucher@...il.com>
> *Sent:* Wednesday, May 24, 2023 3:22 PM
> *To:* Mahfooz, Hamza <Hamza.Mahfooz@....com>
> *Cc:* amd-gfx@...ts.freedesktop.org <amd-gfx@...ts.freedesktop.org>; 
> Li, Sun peng (Leo) <Sunpeng.Li@....com>; Ho, Kenny <Kenny.Ho@....com>; 
> Pan, Xinhui <Xinhui.Pan@....com>; Siqueira, Rodrigo 
> <Rodrigo.Siqueira@....com>; linux-kernel@...r.kernel.org 
> <linux-kernel@...r.kernel.org>; dri-devel@...ts.freedesktop.org 
> <dri-devel@...ts.freedesktop.org>; Daniel Vetter <daniel@...ll.ch>; 
> Deucher, Alexander <Alexander.Deucher@....com>; David Airlie 
> <airlied@...il.com>; Wentland, Harry <Harry.Wentland@....com>; Koenig, 
> Christian <Christian.Koenig@....com>
> *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile 
> checks
>
> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahfooz@....com> 
> wrote:
> >
> > Currently, there are quite a number of issues that are quite easy for
> > the CI to catch, that slip through the cracks. Among them, there are
> > unused variable and indentation issues. Also, we should consider all
> > warnings to be compile errors, since the community will eventually end
> > up complaining about them. So, enable -Werror, -Wunused and
> > -Wmisleading-indentation for all kernel builds.
> >
> > Cc: Alex Deucher <alexander.deucher@....com>
> > Cc: Harry Wentland <harry.wentland@....com>
> > Cc: Kenny Ho <kenny.ho@....com>
> > Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>
> > ---
> > v2: fix grammatical error
> > ---
> >  drivers/gpu/drm/amd/display/Makefile | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/Makefile 
> b/drivers/gpu/drm/amd/display/Makefile
> > index 0d610cb376bb..3c44162ebe21 100644
> > --- a/drivers/gpu/drm/amd/display/Makefile
> > +++ b/drivers/gpu/drm/amd/display/Makefile
> > @@ -26,6 +26,8 @@
> >
> >  AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
> >
> > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation
> > +
>
> Care to enable this for the rest of amdgpu as well?  Or send out an
> additional patch to do that?  Either way:
> Reviewed-by: Alex Deucher <alexander.deucher@....com>
>
> Alex
>
> >  subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
> >  subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
> >  subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr
> > --
> > 2.40.1
> >
>