linux-kernel - Re: [PATCH] adm1266.c: Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e227fe50-1d46-4d84-b869-f0fa74154d02@roeck-us.net>
Date:   Wed, 24 May 2023 15:17:36 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Osama Muhammad <osmtendev@...il.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] adm1266.c: Fix error checking for debugfs_create_dir

On Wed, May 24, 2023 at 09:54:23PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in adm1266.c in
> debugfs_create_dir. The correct way to check if an error occurred
> is using 'IS_ERR' inline function.
> 
> Signed-off-by: Osama Muhammad <osmtendev@...il.com>
> ---
>  drivers/hwmon/pmbus/adm1266.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 1ac2b2f4c570..d88b6115b42e 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -340,7 +340,7 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
>  		return;
>  
>  	data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> -	if (!data->debugfs_dir)
> +	if (IS_ERR(data->debugfs_dir))
>  		return;

Just drop the error check entirely instead. It is not needed.

Thanks,
Guenter

>  
>  	debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,