linux-kernel - Re: [PATCH] selftests: allow runners to override the timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG6WlUZZN4etzM2k@bombadil.infradead.org>
Date:   Wed, 24 May 2023 15:58:29 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kselftest@...r.kernel.org, gregkh@...uxfoundation.org,
        tiwai@...e.de, tianfei.zhang@...el.com, russell.h.weight@...el.com,
        keescook@...omium.org, tweek@...gle.com, a.manzanares@...sung.com,
        dave@...olabs.net, vincenzopalazzodev@...il.com,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        Lucas De Marchi <lucas.de.marchi@...il.com>,
        "Darrick J. Wong" <djwong@...nel.org>
Subject: Re: [PATCH] selftests: allow runners to override the timeout

On Thu, May 11, 2023 at 08:26:42AM -0700, Luis Chamberlain wrote:
> On Fri, Apr 28, 2023 at 1:34 AM Muhammad Usama Anjum
> <usama.anjum@...labora.com> wrote:
> >
> > On 4/15/23 12:38 AM, Luis Chamberlain wrote:
> > > The default timeout for selftests tests is 45 seconds. Although
> > > we already have 13 settings for tests of about 96 sefltests which
> > > use a timeout greater than this, we want to try to avoid encouraging
> > > more tests to forcing a higher test timeout as selftests strives to
> > > run all tests quickly. Selftests also uses the timeout as a non-fatal
> > > error. Only tests runners which have control over a system would know
> > > if to treat a timeout as fatal or not.
> > >
> > > To help with all this:
> > >
> > >   o Enhance documentation to avoid future increases of insane timeouts
> > >   o Add the option to allow overriding the default timeout with test
> > >     runners with a command line option
> > >
> > > Suggested-by: Shuah Khan <skhan@...uxfoundation.org>
> > > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
> > Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> > Tested-by:Muhammad Usama Anjum <usama.anjum@...labora.com>
> 
> Shuah, just a friendly poke! This is needed to allow me to enable full
> automation for kdevops for selftests.

Shuah, friendly re-poke.

  Luis