linux-kernel - Re: [PATCH] misc: Switch i2c drivers back to use .probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230524094344.44baaf45@endymion.delvare>
Date:   Wed, 24 May 2023 09:43:44 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Eric Piel <eric.piel@...mplin-utc.net>,
        Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Serge Semin <fancer.lancer@...il.com>,
        Wolfram Sang <wsa@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Justin Stitt <justinstitt@...gle.com>,
        Yuan Can <yuancan@...wei.com>,
        Dan Carpenter <error27@...il.com>,
        Adrien Grassein <adrien.grassein@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Petr Machata <petrm@...dia.com>, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH] misc: Switch i2c drivers back to use .probe()

On Thu, 18 May 2023 00:01:35 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
> 
> While touching these drivers, fix alignment in apds990x.c and bh1770glc.c.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
> 
> I used v6.4-rc1 as base for this patch, but it also fits on top of
> today's next master. If there are some conflicts when you apply it, feel
> free to just drop all conflicting hunks, I'll care about the fallout
> later.
> 
> I chose to do this in a single patch for all drivers below drivers/misc
> If you want me to split it, just tell me.
> 
> Best regards
> Uwe
> 
>  drivers/misc/ad525x_dpot-i2c.c         | 2 +-
>  drivers/misc/apds9802als.c             | 2 +-
>  drivers/misc/apds990x.c                | 4 ++--
>  drivers/misc/bh1770glc.c               | 4 ++--
>  drivers/misc/ds1682.c                  | 2 +-
>  drivers/misc/eeprom/at24.c             | 2 +-
>  drivers/misc/eeprom/ee1004.c           | 2 +-
>  drivers/misc/eeprom/eeprom.c           | 2 +-
>  drivers/misc/eeprom/idt_89hpesx.c      | 2 +-
>  drivers/misc/eeprom/max6875.c          | 2 +-
>  drivers/misc/hmc6352.c                 | 2 +-
>  drivers/misc/ics932s401.c              | 2 +-
>  drivers/misc/isl29003.c                | 2 +-
>  drivers/misc/isl29020.c                | 2 +-
>  drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 2 +-
>  drivers/misc/tsl2550.c                 | 2 +-
>  16 files changed, 18 insertions(+), 18 deletions(-)
> (...)

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support