linux-kernel - Re: [PATCH 2/2] scsi: pm80xx: Add fatal error check for pm8001_lu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8de540c2-9b85-34ea-5f6d-e440ccce08b9@kernel.org>
Date:   Wed, 24 May 2023 16:55:13 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Pranav Prasad <pranavpp@...gle.com>,
        Jack Wang <jinpu.wang@...ud.ionos.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Igor Pylypiv <ipylypiv@...gle.com>
Subject: Re: [PATCH 2/2] scsi: pm80xx: Add fatal error check for
 pm8001_lu_reset()

On 5/24/23 06:41, Pranav Prasad wrote:
> From: Igor Pylypiv <ipylypiv@...gle.com>
> 
> This patch adds a fatal error check for pm8001_lu_reset().
> 
> Signed-off-by: Igor Pylypiv <ipylypiv@...gle.com>
> Signed-off-by: Pranav Prasad <pranavpp@...gle.com>
> ---
>  drivers/scsi/pm8001/pm8001_sas.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index b153f0966e5d..e302d5879bb7 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -918,6 +918,16 @@ int pm8001_lu_reset(struct domain_device *dev, u8 *lun)
>  	struct pm8001_device *pm8001_dev = dev->lldd_dev;
>  	struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev);
>  	DECLARE_COMPLETION_ONSTACK(completion_setstate);
> +
> +	if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) {
> +		/* If the controller is in fatal error state,
> +		 * we will not get a response from the controller
> +		 */
> +		pm8001_dbg(pm8001_ha, FAIL,
> +				"LUN reset failed due to fatal errors\n");
> +		return rc;
> +	}
> +

Same comments as patch 1. And does this really need to be a separate patch ?
both patches touch the same file, and add a similar change to 2 functions, so I
would fold this in patch 1.

>  	if (dev_is_sata(dev)) {
>  		struct sas_phy *phy = sas_get_local_phy(dev);
>  		sas_execute_internal_abort_dev(dev, 0, NULL);

-- 
Damien Le Moal
Western Digital Research