linux-kernel - Re: [PATCH] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 May 2023 10:43:26 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
Cc:     peterhuewe@....de, jarkko@...nel.org, jgg@...pe.ca,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        l.sanfilippo@...bus.com, jsnitsel@...hat.com
Subject: Re: [PATCH] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only

Dear Peter,


Thank you for your patch.

Am 24.05.23 um 07:58 schrieb Peter Ujfalusi:
> The original patch which added the quirk would apply to all AAEON machines,
> which might or might not be valid.
> 
> The issue was discovered on UPX-i11 (TigerLake), it is not known if the
> i12 (AlderLake) version is affected.
> UP2 (ApolloLake) does not even have TMP module (no TPM drivers probing

s/TMP/TPM/

> and confirmed by dmidecode).

Another nit, the official spelling of the SOC names is with a space, for 
example, Tiger Lake [1].

> Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.
> 
> Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
> Suggested-by: Jerry Snitselaar <jsnitsel@...hat.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
> ---
> Hi Jarkko,
> 
> the patch is generated on top of your
> git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm
> 
> Regards,
> Peter
> 
>   drivers/char/tpm/tpm_tis.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 7db3593941ea..4357d4ba8f9e 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
>   		.ident = "UPX-TGL",
>   		.matches = {
>   			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
>   		},
>   	},
>   	{}

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul


[1]: https://en.wikipedia.org/wiki/Tiger_Lake