linux-kernel - [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230524085844.11580-1-peter.ujfalusi@linux.intel.com>
Date:   Wed, 24 May 2023 11:58:44 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To:     peterhuewe@....de, jarkko@...nel.org
Cc:     jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, l.sanfilippo@...bus.com,
        peter.ujfalusi@...ux.intel.com, jsnitsel@...hat.com,
        pmenzel@...gen.mpg.de
Subject: [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only

The original patch which added the quirk would apply to all AAEON machines,
which might or might not be valid.

The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the
i12 (Alder Lake) version is affected.
UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing
and confirmed by dmidecode).

Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.

Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
Suggested-by: Jerry Snitselaar <jsnitsel@...hat.com>
Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
---
Hi Jarkko,

Changes since v1:
- Findings from Paul Menzel in the commit message has been addressed

the patch is generated on top of your
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm

Regards,
Peter

 drivers/char/tpm/tpm_tis.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 7db3593941ea..4357d4ba8f9e 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
 		.ident = "UPX-TGL",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
 		},
 	},
 	{}
-- 
2.40.1