linux-kernel - Re: [PATCH 2/2] tpm, tpm_tis: reuse code in disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CSU49W63M584.3VBYBMYWJZ3H5@suppilovahvero>
Date:   Wed, 24 May 2023 04:29:00 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Lino Sanfilippo" <l.sanfilippo@...bus.com>,
        "Lino Sanfilippo" <LinoSanfilippo@....de>, <peterhuewe@....de>,
        <jgg@...pe.ca>
Cc:     <jsnitsel@...hat.com>, <hdegoede@...hat.com>,
        <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
        <peter.ujfalusi@...ux.intel.com>, <peterz@...radead.org>,
        <linux@...ewoehner.de>, <linux-integrity@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lukas@...ner.de>,
        <p.rosenberger@...bus.com>
Subject: Re: [PATCH 2/2] tpm, tpm_tis: reuse code in disable_interrupts()

On Tue May 23, 2023 at 11:52 PM EEST, Lino Sanfilippo wrote:
>
>
> On 23.05.23 21:07, Jarkko Sakkinen wrote:
>
> > 
> > NAK as invidual change w/o further discussion.
> > 
> > Would need to be seen in context. This does not change kernel for
> > better.
> > 
> > If you want to wrap, please do it in 1/2 and then we can evaluate
> > whether it makes sense or not.
> > 
>
> Ok, will do so.

And generally: keep it *minimal* :-) We want to exactly fix the bug,
and take absolutely no other action.

BR, Jarkko