linux-kernel - Re: [PATCH v4 13/23] cxl/hdm: Use stored Component Register mappings to map HDM decoder capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG3cpEj9k8S9DMAA@rric.localdomain>
Date:   Wed, 24 May 2023 11:49:22 +0200
From:   Robert Richter <rrichter@....com>
To:     kernel test robot <lkp@...el.com>
CC:     Terry Bowman <terry.bowman@....com>, <alison.schofield@...el.com>,
        <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
        <bwidawsk@...nel.org>, <dan.j.williams@...el.com>,
        <dave.jiang@...el.com>, <Jonathan.Cameron@...wei.com>,
        <linux-cxl@...r.kernel.org>, <oe-kbuild-all@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, <bhelgaas@...gle.com>
Subject: Re: [PATCH v4 13/23] cxl/hdm: Use stored Component Register mappings
 to map HDM decoder capability

On 24.05.23 09:12:24, kernel test robot wrote:

> >> drivers/cxl/core/hdm.c:128:26: warning: no previous prototype for 'cxl_port_get_comp_map' [-Wmissing-prototypes]
>      128 | struct cxl_register_map *cxl_port_get_comp_map(struct cxl_port *port)
>          |                          ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/cxl_port_get_comp_map +128 drivers/cxl/core/hdm.c
> 
>    127	
>  > 128	struct cxl_register_map *cxl_port_get_comp_map(struct cxl_port *port)

This should have been 'static' and also solves the warning then. Will
change.

-Robert

>    129	{
>    130		/*
>    131		 * HDM capability applies to Endpoints, USPs and VH Host
>    132		 * Bridges. The Endpoint's component register mappings are
>    133		 * located in the cxlds.
>    134		 */
>    135		if (is_cxl_endpoint(port)) {
>    136			struct cxl_memdev *memdev = to_cxl_memdev(port->uport);
>    137	
>    138			return &memdev->cxlds->comp_map;
>    139		}
>    140	
>    141		return &port->comp_map;
>    142	}
>    143