linux-kernel - Re: [PATCH v2 3/4] vmlinux.lds.h: use correct .init.data.* section name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d609a02-1877-bb4d-a0ef-6ba7c838b7e4@huawei.com>
Date:   Wed, 24 May 2023 19:02:57 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Jisheng Zhang <jszhang@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Arnd Bergmann <arnd@...db.de>
CC:     <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-arch@...r.kernel.org>, Nicholas Piggin <npiggin@...il.com>
Subject: Re: [PATCH v2 3/4] vmlinux.lds.h: use correct .init.data.* section
 name



On 2023/5/24 0:55, Jisheng Zhang wrote:
> If building with -fdata-sections on riscv, LD_ORPHAN_WARN will warn
> similar as below:
> 
> riscv64-linux-gnu-ld: warning: orphan section `.init.data.efi_loglevel'
> from `./drivers/firmware/efi/libstub/printk.stub.o' being placed in
> section `.init.data.efi_loglevel'
> 
> I believe this is caused by a a typo:
> init.data.* should be .init.data.*

Fixes tag?

266ff2a8f51f kbuild: Fix asm-generic/vmlinux.lds.h for 
LD_DEAD_CODE_DATA_ELIMINATION

Reviewed-by: Kefeng Wang <wangkefeng.wang@...wei.com>


> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>   include/asm-generic/vmlinux.lds.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index d1f57e4868ed..371026ca7221 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -688,7 +688,7 @@
>   /* init and exit section handling */
>   #define INIT_DATA							\
>   	KEEP(*(SORT(___kentry+*)))					\
> -	*(.init.data init.data.*)					\
> +	*(.init.data .init.data.*)					\
>   	MEM_DISCARD(init.data*)						\
>   	KERNEL_CTORS()							\
>   	MCOUNT_REC()							\