linux-kernel - Re: [PATCH] sched/psi: make psi_cgroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpEP0m+4fdTSvY5TuWwvvpiQntG5OBhSmEMJipoX75eNLg@mail.gmail.com>
Date:   Thu, 25 May 2023 10:43:34 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     hannes@...xchg.org, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/psi: make psi_cgroups_enabled static

On Wed, May 24, 2023 at 7:43 PM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Suren Baghdasaryan <surenb@...gle.com>

> ---
>  kernel/sched/psi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 81fca77397f6..2ccb0b2ebd78 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -140,7 +140,7 @@
>  static int psi_bug __read_mostly;
>
>  DEFINE_STATIC_KEY_FALSE(psi_disabled);
> -DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
> +static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
>
>  #ifdef CONFIG_PSI_DEFAULT_DISABLED
>  static bool psi_enable;
> --
> 2.27.0
>