linux-kernel - RE: [PATCH tty v1 2/8] serial: core: lock port for stop_rx() in uart_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 May 2023 17:47:05 +0000
From:   "Vijaya Krishna Nivarthi (Temp) (QUIC)" <quic_vnivarth@...cinc.com>
To:     John Ogness <john.ogness@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Petr Mladek <pmladek@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "Vijaya Krishna Nivarthi (Temp) (QUIC)" <quic_vnivarth@...cinc.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "dianders@...omium.org" <dianders@...omium.org>
Subject: RE: [PATCH tty v1 2/8] serial: core: lock port for stop_rx() in
 uart_suspend_port()

++Doug

Hi,


> -----Original Message-----
> From: John Ogness <john.ogness@...utronix.de>
> Sent: Thursday, May 25, 2023 3:02 PM
> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Petr Mladek <pmladek@...e.com>; Thomas Gleixner
> <tglx@...utronix.de>; linux-kernel@...r.kernel.org; Jiri Slaby
> <jirislaby@...nel.org>; Vijaya Krishna Nivarthi (Temp) (QUIC)
> <quic_vnivarth@...cinc.com>; linux-serial@...r.kernel.org
> Subject: [PATCH tty v1 2/8] serial: core: lock port for stop_rx() in
> uart_suspend_port()
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
> 
> The uarts_ops stop_rx() callback expects that the port->lock is taken and
> interrupts are disabled.
> 
> Fixes: c9d2325cdb92 ("serial: core: Do stop_rx in suspend path for console if
> console_suspend is disabled")
> Signed-off-by: John Ogness <john.ogness@...utronix.de>
> ---
>  drivers/tty/serial/serial_core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 4b98d13555c0..37ad53616372 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2333,8 +2333,11 @@ int uart_suspend_port(struct uart_driver *drv,
> struct uart_port *uport)
>          * able to Re-start_rx later.
>          */
>         if (!console_suspend_enabled && uart_console(uport)) {
> -               if (uport->ops->start_rx)
> +               if (uport->ops->start_rx) {
> +                       spin_lock_irq(&uport->lock);
>                         uport->ops->stop_rx(uport);
> +                       spin_unlock_irq(&uport->lock);
> +               }


Looks correct to me.
Thank you for the fix.

-Vijay/


>                 goto unlock;
>         }
> 
> --
> 2.30.2