linux-kernel - Re: [PATCH] ucd9000.c: Drop error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <efe65d37-0e15-4685-b071-5ddf2b07c6ef@roeck-us.net>
Date:   Thu, 25 May 2023 11:20:58 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Osama Muhammad <osmtendev@...il.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ucd9000.c: Drop error checking for debugfs_create_dir

On Thu, May 25, 2023 at 09:13:13PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in ucd9000.c.

Sure, but you should also explain what is wrong with the code
(i.e., that debugfs_create_dir() does not return NULL but an ERR_PTR
after an error).

> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
> 

If you plan t send more patches, please watch out for the subject line
to match subject lines used in a subsystem. Here it should start with
something like

hwmon: (pmbus/ucd9000) ...

Thanks,
Guenter

> Signed-off-by: Osama Muhammad <osmtendev@...il.com>
> ---
>  drivers/hwmon/pmbus/ucd9000.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
> index 3daaf2237832..73559afa8ba7 100644
> --- a/drivers/hwmon/pmbus/ucd9000.c
> +++ b/drivers/hwmon/pmbus/ucd9000.c
> @@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
>  		return -ENOENT;
>  
>  	data->debugfs = debugfs_create_dir(client->name, debugfs);
> -	if (!data->debugfs)
> -		return -ENOENT;
>  
>  	/*
>  	 * Of the chips this driver supports, only the UCD9090, UCD90160,
> -- 
> 2.34.1
>