lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202305260341.0cOu5huk-lkp@intel.com>
Date:   Fri, 26 May 2023 03:29:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lior Nahmanson <liorna@...dia.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Raed Salem <raeds@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:1183:13:
 sparse: sparse: restricted __be64 degrades to integer

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   eb03e318135419b8b781f83cdfa7dbb9252afad6
commit: 3b20949cb21bac26d50cdcc58896802a890cfe15 net/mlx5e: Add MACsec RX steering rules
date:   9 months ago
config: mips-randconfig-s033-20230525
compiler: mips64-linux-gcc (GCC) 12.1.0
reproduce:
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3b20949cb21bac26d50cdcc58896802a890cfe15
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 3b20949cb21bac26d50cdcc58896802a890cfe15
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/ drivers/soc/fsl/qe/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305260341.0cOu5huk-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:1183:13: sparse: sparse: restricted __be64 degrades to integer

vim +1183 drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c

  1105	
  1106	static union mlx5e_macsec_rule *
  1107	macsec_fs_rx_add_rule(struct mlx5e_macsec_fs *macsec_fs,
  1108			      const struct macsec_context *macsec_ctx,
  1109			      struct mlx5_macsec_rule_attrs *attrs,
  1110			      u32 fs_id)
  1111	{
  1112		u8 action[MLX5_UN_SZ_BYTES(set_add_copy_action_in_auto)] = {};
  1113		struct mlx5e_macsec_rx *rx_fs = macsec_fs->rx_fs;
  1114		struct net_device *netdev = macsec_fs->netdev;
  1115		struct mlx5_modify_hdr *modify_hdr = NULL;
  1116		struct mlx5_flow_destination dest = {};
  1117		struct mlx5e_macsec_tables *rx_tables;
  1118		union mlx5e_macsec_rule *macsec_rule;
  1119		struct mlx5e_macsec_rx_rule *rx_rule;
  1120		struct mlx5_flow_act flow_act = {};
  1121		struct mlx5e_flow_table *ft_crypto;
  1122		struct mlx5_flow_handle *rule;
  1123		struct mlx5_flow_spec *spec;
  1124		int err = 0;
  1125	
  1126		spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
  1127		if (!spec)
  1128			return NULL;
  1129	
  1130		err = macsec_fs_rx_ft_get(macsec_fs);
  1131		if (err)
  1132			goto out_spec;
  1133	
  1134		macsec_rule = kzalloc(sizeof(*macsec_rule), GFP_KERNEL);
  1135		if (!macsec_rule) {
  1136			macsec_fs_rx_ft_put(macsec_fs);
  1137			goto out_spec;
  1138		}
  1139	
  1140		rx_rule = &macsec_rule->rx_rule;
  1141		rx_tables = &rx_fs->tables;
  1142		ft_crypto = &rx_tables->ft_crypto;
  1143	
  1144		/* Set bit[31 - 30] macsec marker - 0x01 */
  1145		/* Set bit[3-0] fs id */
  1146		MLX5_SET(set_action_in, action, action_type, MLX5_ACTION_TYPE_SET);
  1147		MLX5_SET(set_action_in, action, field, MLX5_ACTION_IN_FIELD_METADATA_REG_B);
  1148		MLX5_SET(set_action_in, action, data, fs_id | BIT(30));
  1149		MLX5_SET(set_action_in, action, offset, 0);
  1150		MLX5_SET(set_action_in, action, length, 32);
  1151	
  1152		modify_hdr = mlx5_modify_header_alloc(macsec_fs->mdev, MLX5_FLOW_NAMESPACE_KERNEL_RX_MACSEC,
  1153						      1, action);
  1154		if (IS_ERR(modify_hdr)) {
  1155			err = PTR_ERR(modify_hdr);
  1156			netdev_err(netdev, "fail to alloc MACsec set modify_header_id err=%d\n", err);
  1157			modify_hdr = NULL;
  1158			goto err;
  1159		}
  1160		rx_rule->meta_modhdr = modify_hdr;
  1161	
  1162		/* Rx crypto table with SCI rule */
  1163		macsec_fs_rx_setup_fte(spec, &flow_act, attrs, true);
  1164	
  1165		flow_act.modify_hdr = modify_hdr;
  1166		flow_act.action = MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |
  1167				  MLX5_FLOW_CONTEXT_ACTION_CRYPTO_DECRYPT |
  1168				  MLX5_FLOW_CONTEXT_ACTION_MOD_HDR;
  1169	
  1170		dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
  1171		dest.ft = rx_tables->ft_check;
  1172		rule = mlx5_add_flow_rules(ft_crypto->t, spec, &flow_act, &dest, 1);
  1173		if (IS_ERR(rule)) {
  1174			err = PTR_ERR(rule);
  1175			netdev_err(netdev,
  1176				   "Failed to add SA with SCI rule to Rx crypto rule, err=%d\n",
  1177				   err);
  1178			goto err;
  1179		}
  1180		rx_rule->rule[0] = rule;
  1181	
  1182		/* Rx crypto table without SCI rule */
> 1183		if (cpu_to_be64((__force u64)attrs->sci) & ntohs(MACSEC_PORT_ES)) {
  1184			memset(spec, 0, sizeof(struct mlx5_flow_spec));
  1185			memset(&dest, 0, sizeof(struct mlx5_flow_destination));
  1186			memset(&flow_act, 0, sizeof(flow_act));
  1187	
  1188			macsec_fs_rx_setup_fte(spec, &flow_act, attrs, false);
  1189	
  1190			flow_act.modify_hdr = modify_hdr;
  1191			flow_act.action = MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |
  1192					  MLX5_FLOW_CONTEXT_ACTION_CRYPTO_DECRYPT |
  1193					  MLX5_FLOW_CONTEXT_ACTION_MOD_HDR;
  1194	
  1195			dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
  1196			dest.ft = rx_tables->ft_check;
  1197			rule = mlx5_add_flow_rules(ft_crypto->t, spec, &flow_act, &dest, 1);
  1198			if (IS_ERR(rule)) {
  1199				err = PTR_ERR(rule);
  1200				netdev_err(netdev,
  1201					   "Failed to add SA without SCI rule to Rx crypto rule, err=%d\n",
  1202					   err);
  1203				goto err;
  1204			}
  1205			rx_rule->rule[1] = rule;
  1206		}
  1207	
  1208		return macsec_rule;
  1209	
  1210	err:
  1211		macsec_fs_rx_del_rule(macsec_fs, rx_rule);
  1212		macsec_rule = NULL;
  1213	out_spec:
  1214		kvfree(spec);
  1215		return macsec_rule;
  1216	}
  1217	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (187458 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ