linux-kernel - Re: [PATCH -next] block: Fix the partition start may overflow in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG8igEyXrFa4j/gf@infradead.org>
Date:   Thu, 25 May 2023 01:55:28 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Zhong Jinghua <zhongjinghua@...weicloud.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhongjinghua@...wei.com,
        yi.zhang@...wei.com, yukuai3@...wei.com, chengzhihao1@...wei.com,
        yangerkun@...wei.com
Subject: Re: [PATCH -next] block: Fix the partition start may overflow in
 add_partition()

On Mon, May 22, 2023 at 03:06:15PM +0800, Zhong Jinghua wrote:
> +	if (p.start < 0 || p.length <= 0 || p.start + p.length < 0)
> +		return -EINVAL;
> +
>  	start = p.start >> SECTOR_SHIFT;
>  	length = p.length >> SECTOR_SHIFT;
>  
> +	/* length may be equal to 0 after right shift */
> +	if (!length || start + length > get_capacity(bdev->bd_disk))
> +		return -EINVAL;

While we're at it, shouldn't these be switched to use
check_add_overflow?