linux-kernel - Re: [PATCH v2 2/2] misc: enclosure: update sysfs api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZG8s2EV0xvNH+0Cb@infradead.org>
Date:   Thu, 25 May 2023 02:39:36 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Mariusz Tkaczyk <mariusz.tkaczyk@...ux.intel.com>
Cc:     arnd@...db.de, andriy.shevchenko@...el.com,
        linux-kernel@...r.kernel.org, dan.j.williams@...el.com
Subject: Re: [PATCH v2 2/2] misc: enclosure: update sysfs api

On Wed, May 24, 2023 at 01:12:31PM +0200, Mariusz Tkaczyk wrote:
> Use DEVICE_ATTR RW and RO macros. Update function names accordingly.
> No functional changes intended.

The subject looks a bit, I'd say something like:

"enclosure: use DEVICE_ATTR_RW* macros"

instead.

The actual changes look good to me:

Reviewed-by: Christoph Hellwig <hch@....de>