linux-kernel - Re: [PATCH] mfd: intel-lpss: hide suspend/resume functions in #ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230525103124.GC9691@google.com>
Date:   Thu, 25 May 2023 11:31:24 +0100
From:   Lee Jones <lee@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: hide suspend/resume functions in #ifdef

On Tue, 16 May 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> When CONFIG_PM is disabled, the prototypes for these two functions
> are not visible:
> 
> drivers/mfd/intel-lpss.c:482:5: error: no previous prototype for 'intel_lpss_suspend' [-Werror=missing-prototypes]
>   482 | int intel_lpss_suspend(struct device *dev)
>       |     ^~~~~~~~~~~~~~~~~~
> drivers/mfd/intel-lpss.c:503:5: error: no previous prototype for 'intel_lpss_resume' [-Werror=missing-prototypes]
>   503 | int intel_lpss_resume(struct device *dev)
> 
> Add the same #ifdef around the definition of the unused functions,
> which avoids the warning and slightly reduces the code size.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/intel-lpss.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

-- 
Lee Jones [李琼斯]