linux-kernel - Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230525105003.GF9691@google.com>
Date:   Thu, 25 May 2023 11:50:03 +0100
From:   Lee Jones <lee@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Tony Lindgren <tony@...mide.com>,
        Russell King <linux@...linux.org.uk>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Andreas Kemnade <andreas@...nade.info>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver

On Mon, 01 May 2023, Linus Walleij wrote:

> The TWL4030 GPIO driver has a custom platform data .set_up()
> callback to call back into the platform and do misc stuff such
> as hog and export a GPIO for WLAN PWR on a specific OMAP3 board.
> 
> Avoid all the kludgery in the platform data and the boardfile
> and just put the quirks right into the driver. Make it
> conditional on OMAP3.
> 
> I think the exported GPIO is used by some kind of userspace
> so ordinary DTS hogs will probably not work.
> 
> Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base")
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  arch/arm/mach-omap2/omap_device.c  |  1 -
>  arch/arm/mach-omap2/pdata-quirks.c | 41 +-----------------------------
>  drivers/gpio/gpio-twl4030.c        | 52 ++++++++++++++++++++++++++------------

>  include/linux/mfd/twl.h            |  3 ---

Acked-by: Lee Jones <lee@...nel.org>

>  4 files changed, 37 insertions(+), 60 deletions(-)

-- 
Lee Jones [李琼斯]