linux-kernel - Re: [PATCH] led: qcom-lpg: Fix resource leaks in for_each_available_child_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230525120223.GB443478@google.com>
Date:   Thu, 25 May 2023 13:02:23 +0100
From:   Lee Jones <lee@...nel.org>
To:     Lu Hongfei <luhongfei@...o.com>
Cc:     Pavel Machek <pavel@....cz>,
        Anjelique Melendez <quic_amelende@...cinc.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Lu Hongfei <11117923@...tel.com>,
        "open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com
Subject: Re: [PATCH] led: qcom-lpg: Fix resource leaks in
 for_each_available_child_of_node() loops

On Thu, 25 May 2023, Lu Hongfei wrote:

> for_each_available_child_of_node in lpg_probe and lpg_add_led need
> to execute of_node_put before return. this patch could fix this bug.
> 
> Signed-off-by: Lu Hongfei <luhongfei@...o.com>
> ---
>  drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>  mode change 100644 => 100755 drivers/leds/rgb/leds-qcom-lpg.c

I made a few tweaks to the commit messaged.

Applied, thanks

-- 
Lee Jones [李琼斯]