linux-kernel - Re: [PATCH v3 2/5] soc: qcom: smem: Switch to EXPORT_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 May 2023 14:12:13 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Robert Marko <robimarko@...il.com>, agross@...nel.org,
        andersson@...nel.org, ilia.lin@...nel.org, rafael@...nel.org,
        viresh.kumar@...aro.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org
Cc:     ansuelsmth@...il.com
Subject: Re: [PATCH v3 2/5] soc: qcom: smem: Switch to EXPORT_SYMBOL_GPL()



On 25.05.2023 14:09, Robert Marko wrote:
> SMEM has been GPL licensed from the start, and there is no reason to use
> EXPORT_SYMBOL() so switch to the GPL version.
> 
> Signed-off-by: Robert Marko <robimarko@...il.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  drivers/soc/qcom/smem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 6be7ea93c78c..bc98520c4969 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -500,7 +500,7 @@ int qcom_smem_alloc(unsigned host, unsigned item, size_t size)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(qcom_smem_alloc);
> +EXPORT_SYMBOL_GPL(qcom_smem_alloc);
>  
>  static void *qcom_smem_get_global(struct qcom_smem *smem,
>  				  unsigned item,
> @@ -674,7 +674,7 @@ void *qcom_smem_get(unsigned host, unsigned item, size_t *size)
>  	return ptr;
>  
>  }
> -EXPORT_SYMBOL(qcom_smem_get);
> +EXPORT_SYMBOL_GPL(qcom_smem_get);
>  
>  /**
>   * qcom_smem_get_free_space() - retrieve amount of free space in a partition
> @@ -719,7 +719,7 @@ int qcom_smem_get_free_space(unsigned host)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(qcom_smem_get_free_space);
> +EXPORT_SYMBOL_GPL(qcom_smem_get_free_space);
>  
>  static bool addr_in_range(void __iomem *base, size_t size, void *addr)
>  {
> @@ -770,7 +770,7 @@ phys_addr_t qcom_smem_virt_to_phys(void *p)
>  
>  	return 0;
>  }
> -EXPORT_SYMBOL(qcom_smem_virt_to_phys);
> +EXPORT_SYMBOL_GPL(qcom_smem_virt_to_phys);
>  
>  static int qcom_smem_get_sbl_version(struct qcom_smem *smem)
>  {