| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 May 2023 10:41:51 +0800
From: "lihuisong (C)" <lihuisong@...wei.com>
To: Sudeep Holla <sudeep.holla@....com>
CC: <andersson@...nel.org>, <matthias.bgg@...il.com>,
<angelogioacchino.delregno@...labora.com>, <shawnguo@...nel.org>,
<arnd@...db.de>, <krzk@...nel.org>, <linux-kernel@...r.kernel.org>,
<soc@...nel.org>, <wanghuiqiang@...wei.com>,
<tanxiaofei@...wei.com>, <liuyonglong@...wei.com>
Subject: Re: [PATCH v2 1/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC
在 2023/5/23 17:39, Sudeep Holla 写道:
> On Mon, May 22, 2023 at 03:22:10PM +0800, Huisong Li wrote:
>> The Huawei Cache-Coherent System (HCCS) is a bus protocol standard
>> for ensuring cache coherent on HiSilicon SoC. The performance of
>> the application may be affected if some hccs ports are in non-full
>> lane status, have a large number of CRC errors and so on.
>>
>> This driver provides the query interface of the health status and
>> port information of HCCS on Kunpeng SoC.
>>
>> Signed-off-by: Huisong Li <lihuisong@...wei.com>
>> ---
>> MAINTAINERS | 6 +
>> drivers/soc/Kconfig | 1 +
>> drivers/soc/Makefile | 1 +
>> drivers/soc/hisilicon/Kconfig | 19 +
>> drivers/soc/hisilicon/Makefile | 2 +
>> drivers/soc/hisilicon/kunpeng_hccs.c | 1287 ++++++++++++++++++++++++++
>> drivers/soc/hisilicon/kunpeng_hccs.h | 196 ++++
>> 7 files changed, 1512 insertions(+)
>> create mode 100644 drivers/soc/hisilicon/Kconfig
>> create mode 100644 drivers/soc/hisilicon/Makefile
>> create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.c
>> create mode 100644 drivers/soc/hisilicon/kunpeng_hccs.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index eddbc48c61e9..fe0e796e8445 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -9399,6 +9399,12 @@ S: Maintained
>> W: http://www.hisilicon.com
>> F: drivers/spi/spi-hisi-sfc-v3xx.c
>>
>> +HISILICON KUNPENG SOC HCCS DRIVER
> s/HCCS/HCCS INFO or QUERY/ ?
>
>> +M: Huisong Li <lihuisong@...wei.com>
>> +S: Maintained
>> +F: drivers/soc/hisilicon/kunpeng_hccs.c
>> +F: drivers/soc/hisilicon/kunpeng_hccs.h
>> +
>> HMM - Heterogeneous Memory Management
>> M: Jérôme Glisse <jglisse@...hat.com>
>> L: linux-mm@...ck.org
>> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
>> index 4e176280113a..d21e75d69294 100644
>> --- a/drivers/soc/Kconfig
>> +++ b/drivers/soc/Kconfig
>> @@ -10,6 +10,7 @@ source "drivers/soc/bcm/Kconfig"
>> source "drivers/soc/canaan/Kconfig"
>> source "drivers/soc/fsl/Kconfig"
>> source "drivers/soc/fujitsu/Kconfig"
>> +source "drivers/soc/hisilicon/Kconfig"
>> source "drivers/soc/imx/Kconfig"
>> source "drivers/soc/ixp4xx/Kconfig"
>> source "drivers/soc/litex/Kconfig"
>> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
>> index 3b0f9fb3b5c8..531f46f3ad98 100644
>> --- a/drivers/soc/Makefile
>> +++ b/drivers/soc/Makefile
>> @@ -14,6 +14,7 @@ obj-$(CONFIG_MACH_DOVE) += dove/
>> obj-y += fsl/
>> obj-y += fujitsu/
>> obj-$(CONFIG_ARCH_GEMINI) += gemini/
>> +obj-y += hisilicon/
>> obj-y += imx/
>> obj-y += ixp4xx/
>> obj-$(CONFIG_SOC_XWAY) += lantiq/
>> diff --git a/drivers/soc/hisilicon/Kconfig b/drivers/soc/hisilicon/Kconfig
>> new file mode 100644
>> index 000000000000..87a1f15cbedb
>> --- /dev/null
>> +++ b/drivers/soc/hisilicon/Kconfig
>> @@ -0,0 +1,19 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +
>> +menu "Hisilicon SoC drivers"
>> + depends on ARCH_HISI || COMPILE_TEST
>> +
>> +config KUNPENG_HCCS
> Ditto, add INFO or QUERY to the name as HCCS alone suggests it is some
> driver to manage the above bus protocol which is not correct.
>
>> + tristate "HCCS driver on Kunpeng SoC"
>> + depends on ACPI
>> + depends on ARM64 || COMPILE_TEST
>> + help
>> + The Huawei Cache-Coherent System (HCCS) is a bus protocol standard
>> + for ensuring cache coherent on HiSilicon SoC. The performance of
>> + the application may be affected if some hccs ports are in non-full
>> + lane status, have a large number of CRC errors and so on.
>> +
>> + Say M here if you want to include support for querying the health
>> + status and port information of HCCS on Kunpeng SoC.
>> +
>> +endmenu
>> diff --git a/drivers/soc/hisilicon/Makefile b/drivers/soc/hisilicon/Makefile
>> new file mode 100644
>> index 000000000000..226e747e70d6
>> --- /dev/null
>> +++ b/drivers/soc/hisilicon/Makefile
>> @@ -0,0 +1,2 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +obj-$(CONFIG_KUNPENG_HCCS) += kunpeng_hccs.o
>> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
>> new file mode 100644
>> index 000000000000..20a506a04bb7
>> --- /dev/null
>> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
>> @@ -0,0 +1,1287 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * The Huawei Cache-Coherent System (HCCS) is a bus protocol standard for
>> + * ensuring cache coherent on HiSilicon SoC.
>> + *
>> + * Copyright (c) 2023 Hisilicon Limited.
>> + * Author: Huisong Li <lihuisong@...wei.com>
>> + *
>> + * HCCS driver for Kunpeng SoC provides the following features:
>> + * - Retrieve info as belows each port:
> [snip]
>
>> + * - port type
>> + * - lane mode
>> + * - using status
> perhaps just status, "using status" doesn't sound correct to me.
>
>
Hi Sudeep,
Here, the interface is used to determine whether a port is in use or
enabled.
If we just use 'status', it cannot inidicates its own meaning by name.
What do you think?
/Huisong
[snip]
Powered by blists - more mailing lists