[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <CSVF1AQBGQU0.1V5KJP08TCKLT@burritosblues>
Date: Thu, 25 May 2023 16:07:39 +0200
From: "Esteban Blanc" <eblanc@...libre.com>
To: <andy.shevchenko@...il.com>
Cc: <linus.walleij@...aro.org>, <lgirdwood@...il.com>,
<broonie@...nel.org>, <a.zummo@...ertech.it>,
<alexandre.belloni@...tlin.com>, <linux-kernel@...r.kernel.org>,
<linux-gpio@...r.kernel.org>, <linux-rtc@...r.kernel.org>,
<jpanis@...libre.com>, <jneanne@...libre.com>,
<aseketeli@...libre.com>, <u-kumar1@...com>
Subject: Re: [PATCH v5 2/3] pinctrl: tps6594: Add driver for TPS6594 pinctrl
and GPIOs
On Tue May 23, 2023 at 9:14 PM CEST, wrote:
> Mon, May 22, 2023 at 06:31:14PM +0200, Esteban Blanc kirjoitti:
> > TI TPS6594 PMIC has 11 GPIOs which can be used
> > for different functions.
> >
> > This patch adds a pinctrl and GPIO drivers in
> > order to use those functions.
>
> ...
>
> > +#define FUNCTION(n, g, v) \
> > + { \
> > + .pinfunction = PINCTRL_PINFUNCTION((n), (g), ARRAY_SIZE(g)), \
> > + .muxval = v, \
> > + }
>
> It seems you have used SPACEs before \, can you move to TABs?
Once again clang-format is not doing the right thing. Sur I will fix
this.
> > +// Used to compute register address of GPIO1_CONF to GPIO11_CONF
>
> This is good.
>
> > -#define TPS6594_REG_GPIOX_CONF(gpio_inst) (0x31 + (gpio_inst))
> > +#define TPS6594_REG_GPIOX_CONF(gpio_inst) (0x31 + (gpio_inst))
>
> But why this?!
Once again, clang-format... I will fix this.
Thanks for your help.
Best regards,
--
Esteban Blanc
BayLibre
Powered by blists - more mailing lists