linux-kernel - Re: [PATCH v5 0/2] Update section header name check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 25 May 2023 09:32:00 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Cc:     linux-remoteproc@...r.kernel.org, agross@...nel.org,
        andersson@...nel.org, lgirdwood@...il.com, broonie@...nel.org,
        robh+dt@...nel.org, quic_plai@...cinc.com, bgoswami@...cinc.com,
        perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
        quic_rohkumar@...cinc.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, swboyd@...omium.org,
        judyhsiao@...omium.org, devicetree@...r.kernel.org,
        krzysztof.kozlowski@...aro.org, corbet@....net,
        quic_visr@...cinc.com
Subject: Re: [PATCH v5 0/2] Update section header name check

On Thu, May 11, 2023 at 10:09:45PM +0530, Mohammad Rafi Shaik wrote:
> 
> On 3/3/2023 3:27 AM, Mathieu Poirier wrote:
> > On Thu, Feb 23, 2023 at 08:35:57PM +0530, Mohammad Rafi Shaik wrote:
> > > Update section header name check and corresponding documentation.
> > > Changes since v4:
> > >      -- Rephrase commit message.
> > Asked for clarifications on V4 that were never given to me.  This patchset will
> > not move forward until those have been resolved.
> The present Qualcomm DSP binary contains resource table name as
> ".resource_table.ac_bin_process.",

My questions still haven't been answered:

1. Why do we have to change the kernel because of the way a company specific
tool generates an ELF?

2. Why is the "ac_bin_process" part needed at all?

> so the current logic with strcmp will fail with present comparision  as the
> binary name is not only .resource_table but resource_table.ac_bin_process So
> to overcome this issue we modified the way of checking the resource table
> name to make it generic.
> 
> strstarts(name_table + name, ".resource_table");
> 
> This logic will perform a string comparison with name ".resouce_table"as our
> binary name is .resource_table.ac_bin_process it succeeds
> 
> > > Changes since v3:
> > >      -- Rephrase commit message.
> > > Changes since v2:
> > >      -- Update the commit message with example.
> > >      -- Update the documentation text appropriately.
> > > Changes since v1:
> > >      -- Update the commit message.
> > >      -- Use strstarts instead of strstr.
> > >      -- Update documentation file.
> > > 
> > > Srinivasa Rao Mandadapu (2):
> > >    remoteproc: elf_loader: Update resource table name check
> > >    docs: remoteproc: Update section header name requirement
> > > 
> > >   Documentation/staging/remoteproc.rst       | 5 ++++-
> > >   drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
> > >   2 files changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > -- 
> > > 2.25.1
> > >