linux-kernel - Re: wifi: rtw89: use flexible array member in rtw89_btc_btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168503126425.22756.6147214283956787608.kvalo@kernel.org>
Date:   Thu, 25 May 2023 16:14:25 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Ping-Ke Shih <pkshih@...ltek.com>, Arnd Bergmann <arnd@...db.de>,
        Ching-Te Ku <ku920601@...ltek.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: wifi: rtw89: use flexible array member in rtw89_btc_btf_tlv

Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> struct rtw89_btc_btf_tlv contains a one-byte member that is intended as a
> flexible array:
> 
> In function 'fortify_memcpy_chk',
>     inlined from '_append_tdma' at drivers/net/wireless/realtek/rtw89/coex.c:1579:3:
> include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
>   583 |                         __write_overflow_field(p_size_field, size);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Make this actually use a flexible array to let the compiler understand.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Patch applied to wireless-next.git, thanks.

47e612268ea0 wifi: rtw89: use flexible array member in rtw89_btc_btf_tlv

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230523113241.2772811-1-arnd@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches