[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230526-bondless-slather-5de0a5659353@spud>
Date: Fri, 26 May 2023 20:37:10 +0100
From: Conor Dooley <conor@...nel.org>
To: Bharat Bhushan <bbhushan2@...vell.com>
Cc: wim@...ux-watchdog.org, linux@...ck-us.net, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, linux-watchdog@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
sgoutham@...vell.com
Subject: Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI system
watchdog driver
Yo Bharat,
On Fri, May 26, 2023 at 11:56:25AM +0530, Bharat Bhushan wrote:
> Add binding documentation for the Marvell GTI system
> watchdog driver.
>
> Signed-off-by: Bharat Bhushan <bbhushan2@...vell.com>
> ---
> v8:
> - Compatible name as per soc name
I am sorry, but I do not understand this.
>
> .../watchdog/marvell,octeontx2-wdt.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml
> new file mode 100644
> index 000000000000..3c642359d960
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/marvell,octeontx2-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Global Timer (GTI) system watchdog
> +
> +allOf:
> + - $ref: watchdog.yaml#
From v7:
Put allOf after maintainers:.
> +
> +maintainers:
> + - Bharat Bhushan <bbhushan2@...vell.com>
> +
> +properties:
> + compatible:
> + enum:
> + - marvell,cn9670-wdt
> + - marvell,cn9880-wdt
> + - marvell,cnf9535-wdt
> + - marvell,cn10624-wdt
> + - marvell,cn10308-wdt
> + - marvell,cnf10518-wdt
static const struct of_device_id gti_wdt_of_match[] = {
{ .compatible = "marvell,cn9670-wdt", .data = &match_data_octeontx2},
{ .compatible = "marvell,cn9880-wdt", .data = &match_data_octeontx2},
{ .compatible = "marvell,cnf9535-wdt", .data = &match_data_octeontx2},
{ .compatible = "marvell,cn10624-wdt", .data = &match_data_cn10k},
{ .compatible = "marvell,cn10308-wdt", .data = &match_data_cn10k},
{ .compatible = "marvell,cnf10518-wdt", .data = &match_data_cn10k},
This is a fat hint that you should be using fallback compatibles here.
You even had a fallback setup in your last revision, but you seem to
have removed it alongside the removal of the wildcards. Why did you do
that?
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
From v7:
maxItems instead. You see it is different than above properties?
> +
> + clock-names:
> + minItems: 1
From v7:
Need to define names.
Cheers,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists