| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 May 2023 01:02:01 +0300
From: andy.shevchenko@...il.com
To: Mukesh Ojha <quic_mojha@...cinc.com>
Cc: agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
linus.walleij@...aro.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v6 2/5] pinctrl: qcom: Use qcom_scm_io_update_field()
Wed, Mar 29, 2023 at 01:16:49PM +0530, Mukesh Ojha kirjoitti:
> Use qcom_scm_io_update_field() exported function introduced
> in last commit.
...
> u32 val;
> + u32 mask;
Swapping their order may help with readability.
...
> + mask = (7 << g->intr_target_bit);
Why not GENMASK(2, 0) at the same time?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists