linux-kernel - Re: [PATCH 03/31] mm/pgtable: kmap_local_page() instead of kmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHE1zLLF1jfcw8OI@x1n>
Date:   Fri, 26 May 2023 18:42:20 -0400
From:   Peter Xu <peterx@...hat.com>
To:     Hugh Dickins <hughd@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Mike Rapoport <rppt@...nel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        David Hildenbrand <david@...hat.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Qi Zheng <zhengqi.arch@...edance.com>,
        Yang Shi <shy828301@...il.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>, Yu Zhao <yuzhao@...gle.com>,
        Alistair Popple <apopple@...dia.com>,
        Ralph Campbell <rcampbell@...dia.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Steven Price <steven.price@....com>,
        SeongJae Park <sj@...nel.org>,
        Naoya Horiguchi <naoya.horiguchi@....com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Zack Rusin <zackr@...are.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Minchan Kim <minchan@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Song Liu <song@...nel.org>,
        Thomas Hellstrom <thomas.hellstrom@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 03/31] mm/pgtable: kmap_local_page() instead of
 kmap_atomic()

On Fri, May 26, 2023 at 06:22:58PM -0400, Peter Xu wrote:
> On Sun, May 21, 2023 at 09:52:31PM -0700, Hugh Dickins wrote:
> > pte_offset_map() was still using kmap_atomic(): update it to the
> > preferred kmap_local_page() before making further changes there, in case
> > we need this as a bisection point; but I doubt it can cause any trouble.
> > 
> > Signed-off-by: Hugh Dickins <hughd@...gle.com>
> > ---
> >  include/linux/pgtable.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> > index 8ec27fe69dc8..94235ff2706e 100644
> > --- a/include/linux/pgtable.h
> > +++ b/include/linux/pgtable.h
> > @@ -96,9 +96,9 @@ static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address)
> >  
> >  #if defined(CONFIG_HIGHPTE)
> >  #define pte_offset_map(dir, address)				\
> > -	((pte_t *)kmap_atomic(pmd_page(*(dir))) +		\
> > +	((pte_t *)kmap_local_page(pmd_page(*(dir))) +		\
> >  	 pte_index((address)))
> > -#define pte_unmap(pte) kunmap_atomic((pte))
> > +#define pte_unmap(pte) kunmap_local((pte))
> >  #else
> >  #define pte_offset_map(dir, address)	pte_offset_kernel((dir), (address))
> >  #define pte_unmap(pte) ((void)(pte))	/* NOP */
> 
> (I think this could be a dumb question if this patch has been running there
>  for years downstream, but still..)
> 
> I assume one major difference of using kmap_local() is page fault will not
> be disabled, while kmap_atomic() will.
> 
> Meanwhile, pte_offset_map() is also used by pte_offset_map_lock(), which
> means before this patch CONFIG_HIGHPTE systems will disable pgfault before
> taking pgtable lock for it, while it will stop doing so after the change.
> 
> Then what happens if a page fault happens on the same pgtable lock range
> that is already taken by the thread context?  What stops the deadlock from
> happening?

Ah, stupid me.  I think such a page fault just cannot happen when holding
the pgtable lock..  I believe the same applies to !HIGHPTE..

Sorry about the noise.

-- 
Peter Xu