linux-kernel - Re: [PATCH v2 2/8] iio: adc: rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202305261340.VUt3YsQ2-lkp@intel.com>
Date:   Fri, 26 May 2023 14:01:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shreeya Patel <shreeya.patel@...labora.com>, jic23@...nel.org,
        lars@...afoo.de, heiko@...ech.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, sebastian.reichel@...labora.com
Cc:     oe-kbuild-all@...ts.linux.dev, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com, gustavo.padovan@...labora.com,
        serge.broslavsky@...labora.com,
        Shreeya Patel <shreeya.patel@...labora.com>,
        Simon Xue <xxm@...k-chips.com>
Subject: Re: [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588

Hi Shreeya,

kernel test robot noticed the following build errors:

[auto build test ERROR on rockchip/for-next]
[also build test ERROR on jic23-iio/togreg linus/master v6.4-rc3 next-20230525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shreeya-Patel/iio-adc-rockchip_saradc-Add-callback-functions/20230526-053049
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
patch link:    https://lore.kernel.org/r/20230525212712.255406-3-shreeya.patel%40collabora.com
patch subject: [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588
config: powerpc-allmodconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5a4470a7d103b48a89f010f62135eed485969b03
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Shreeya-Patel/iio-adc-rockchip_saradc-Add-callback-functions/20230526-053049
        git checkout 5a4470a7d103b48a89f010f62135eed485969b03
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305261340.VUt3YsQ2-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/adc/rockchip_saradc.c: In function 'rockchip_saradc_start_v2':
>> drivers/iio/adc/rockchip_saradc.c:104:15: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     104 |         val = FIELD_PREP(SARADC2_EN_END_INT, 1);
         |               ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP +104 drivers/iio/adc/rockchip_saradc.c

    94	
    95	static void rockchip_saradc_start_v2(struct rockchip_saradc *info, int chn)
    96	{
    97		int val;
    98	
    99		if (info->reset)
   100			rockchip_saradc_reset_controller(info->reset);
   101	
   102		writel_relaxed(0xc, info->regs + SARADC_T_DAS_SOC);
   103		writel_relaxed(0x20, info->regs + SARADC_T_PD_SOC);
 > 104		val = FIELD_PREP(SARADC2_EN_END_INT, 1);
   105		val |= val << 16;
   106		writel_relaxed(val, info->regs + SARADC2_END_INT_EN);
   107		val = FIELD_PREP(SARADC2_START, 1) |
   108		      FIELD_PREP(SARADC2_SINGLE_MODE, 1) |
   109		      FIELD_PREP(SARADC2_CONV_CHANNELS, chn);
   110		val |= val << 16;
   111		writel(val, info->regs + SARADC2_CONV_CON);
   112	}
   113	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (331425 bytes)