[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f8731d93-b335-6d9a-183c-34a652f45455@linaro.org>
Date: Fri, 26 May 2023 12:59:17 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
Stephen Boyd <sboyd@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Marijn Suijten <marijn.suijten@...ainline.org>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] opp: Provide a function for just setting bandwidth
On 26.05.2023 12:53, Viresh Kumar wrote:
> On 26-05-23, 11:17, Konrad Dybcio wrote:
>> Currently it's not possible to set just the bandwidth if the OPP
>> describes other properties (required-opps, opp-hz etc.).
>>
>> Introduce dev_pm_opp_set_bw() to solve this problem.
>
> The OPP core (intentionally) doesn't provide any such interface for
> freq, volt, bw, level, etc.
>
> Setting just one of the properties for a device is potentially harmful and the
> OPP must be set as a whole and so this isn't allowed. There is
> dev_pm_opp_set_freq(), but it uses freq to just find the OPP and sets entire OPP
> only.
>
> Why should be break this for bw ?
>
There are some users which have tight power sequencing requirements,
like the Qualcomm Adreno GPU.
Dropping the entire OPP kills clocks, bw and required-opps at once,
but on certain Adrenos we need something like:
disable memory clock (clk)
disable all other clocks, including the opp-managed core clock (clk_bulk)
kill one, fully manually controlled genpd (manual runtime pm)
remove bus vote (func proposed in this patch)
kill another genpd (manual runtime pm)
kill the opp-managed genpd (automatic pm calls)
Changing the order kills the chip until you reboot the whole board and
setting freq=0 using dev_pm_opp_set_rate doesn't drop the bw vote.
Konrad
Powered by blists - more mailing lists