linux-kernel - Re: [PATCH] arm64: acpi: Export symbol for acpi_os_ioremap

Open Source and information security mailing list archives

Message-ID: <CAMj1kXHgPbzgPm1Sq5hqqz7RX6sj2axze5F+fvMyfPY=d9=Hhw@mail.gmail.com>
Date:   Fri, 26 May 2023 14:39:10 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Huisong Li <lihuisong@...wei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@...aro.org>
Cc:     catalin.marinas@....com, will@...nel.org, sudeep.holla@....com,
        rafael.j.wysocki@...el.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, anshuman.khandual@....com,
        wangkefeng.wang@...wei.com, liuyonglong@...wei.com
Subject: Re: [PATCH] arm64: acpi: Export symbol for acpi_os_ioremap

(cc Lorenzo)

On Fri, 26 May 2023 at 14:20, Huisong Li <lihuisong@...wei.com> wrote:
>
> The driver who calls the acpi_os_ioremap() cannot be compiled if the 'M'
> is selected for the driver. The compiling log is as follows:
> -->
> MODPOST Module.symvers
> ERROR: modpost: "acpi_os_ioremap" [drivers/soc/hisilicon/xxx.ko] undefined!
> scripts/Makefile.modpost:136: recipe for target 'Module.symvers' failed
> make[1]: *** [Module.symvers] Error 1
>
> So this patch exports symbol for acpi_os_ioremap.
>

That driver does not exist in mainline.

Why does it need to use acpi_os_ioremap() instead of the ordinary
memremap/ioremap routines?

> Signed-off-by: Huisong Li <lihuisong@...wei.com>
> ---
>  arch/arm64/kernel/acpi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
> index dba8fcec7f33..ec0414caf3d1 100644
> --- a/arch/arm64/kernel/acpi.c
> +++ b/arch/arm64/kernel/acpi.c
> @@ -354,6 +354,7 @@ void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size)
>         }
>         return ioremap_prot(phys, size, pgprot_val(prot));
>  }
> +EXPORT_SYMBOL(acpi_os_ioremap);
>
>  /*
>   * Claim Synchronous External Aborts as a firmware first notification.
> --
> 2.33.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives