[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpqSsTxpafOQZBBSZts2ZvxR1Wb6LMdcwnTxZvmyN=OSQA@mail.gmail.com>
Date: Fri, 26 May 2023 16:22:35 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Kathiravan T <quic_kathirav@...cinc.com>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node
On Fri, 26 May 2023 at 15:54, Kathiravan T <quic_kathirav@...cinc.com> wrote:
>
> IPQ6018 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
>
> Signed-off-by: Kathiravan T <quic_kathirav@...cinc.com>
> ---
> Changes in V2:
> - Reorder the node based on node address
>
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index f531797f2619..0f6d6c6daed2 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -302,6 +302,13 @@
> status = "disabled";
> };
>
> + qfprom: efuse@...00 {
> + compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
> + reg = <0x0 0x000a4000 0x0 0x2000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> prng: qrng@...00 {
> compatible = "qcom,prng-ee";
> reg = <0x0 0x000e3000 0x0 0x1000>;
It looks like the prng node name is incorrect. It should be qrng@...00
instead of qrng@...00. Could you please send a followup to fix it?
For this patch:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> --
> 2.17.1
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists