linux-kernel - Re: [PATCH mm-nonmm-unstable 2/2] squashfs: fix page indices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230526133710.GC8803@lst.de>
Date:   Fri, 26 May 2023 15:37:10 +0200
From:   Christoph Hellwig <hch@....de>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     Phillip Lougher <phillip@...ashfs.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>, hch@....de,
        linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH mm-nonmm-unstable 2/2] squashfs: fix page indices

On Fri, May 26, 2023 at 03:25:46PM +0200, Vincent Whitchurch wrote:
> The page cache functions want the page index as an argument but we're
> currently passing in the byte address.

Can you avoid the overly long lines by movning the GFP_NOFS parameters
to the following lines?

The rest look good.