linux-kernel - Re: [PATCH v1 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168511364321.752508.2528911041260451856.robh@kernel.org>
Date:   Fri, 26 May 2023 09:07:23 -0600
From:   Rob Herring <robh@...nel.org>
To:     Frank Li <Frank.Li@....com>
Cc:     shenwei.wang@....com, robh+dt@...nel.org, joy.zou@....com,
        peng.fan@....com, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, imx@...ts.linux.dev,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        vkoul@...nel.org
Subject: Re: [PATCH v1 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3
 compatible string

On Fri, 26 May 2023 10:36:39 -0400, Frank Li wrote:
> Extend Freescale eDMA driver bindings to support eDMA3 IP blocks in
> i.MX8QM and i.MX8QXP SoCs. In i.MX93, both eDMA3 and eDMA4 are now.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../devicetree/bindings/dma/fsl,edma.yaml     | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/dma/fsl,edma.yaml:113:13: [error] duplication of key "const" in mapping (key-duplicates)
./Documentation/devicetree/bindings/dma/fsl,edma.yaml:114:13: [error] duplication of key "const" in mapping (key-duplicates)
./Documentation/devicetree/bindings/dma/fsl,edma.yaml:115:13: [error] duplication of key "const" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/dma/fsl,edma.example.dts'
Documentation/devicetree/bindings/dma/fsl,edma.yaml:113:13: found duplicate key "const" with value "fsl,imx8qm-adma" (original value: "fsl,imx8qm-edma")
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/dma/fsl,edma.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/dma/fsl,edma.yaml:113:13: found duplicate key "const" with value "fsl,imx8qm-adma" (original value: "fsl,imx8qm-edma")
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/fsl,edma.yaml: ignoring, error parsing file
make: *** [Makefile:1512: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230526143639.1037099-13-Frank.Li@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.