| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202305261036.rRlA8YiN-lkp@intel.com>
Date: Fri, 26 May 2023 11:28:28 +0800
From: kernel test robot <lkp@...el.com>
To: Wyes Karny <wyes.karny@....com>, ray.huang@....com,
rafael@...nel.org, viresh.kumar@...aro.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Mario.Limonciello@....com, Jinzhou.Su@....com, Perry.Yuan@....com,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
Wyes Karny <wyes.karny@....com>
Subject: Re: [PATCH 1/2] cpufreq/amd-pstate: Write CPPC enable bit for each
core
Hi Wyes,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master v6.4-rc3 next-20230525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wyes-Karny/cpufreq-amd-pstate-Write-CPPC-enable-bit-for-each-core/20230522-143855
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20230522063325.80193-2-wyes.karny%40amd.com
patch subject: [PATCH 1/2] cpufreq/amd-pstate: Write CPPC enable bit for each core
config: x86_64-buildonly-randconfig-r001-20230525
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6b2af0570adf6fe7c91fa9e839dc11387041c9b4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Wyes-Karny/cpufreq-amd-pstate-Write-CPPC-enable-bit-for-each-core/20230522-143855
git checkout 6b2af0570adf6fe7c91fa9e839dc11387041c9b4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/cpufreq/ kernel/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305261036.rRlA8YiN-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/cpufreq/amd-pstate.c:1374:6: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
if (ret) {
^~~
drivers/cpufreq/amd-pstate.c:1339:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 warning generated.
vim +/ret +1374 drivers/cpufreq/amd-pstate.c
ffa5096a7c3386 Perry Yuan 2023-01-31 1335
ec437d71db77a1 Huang Rui 2021-12-24 1336 static int __init amd_pstate_init(void)
ec437d71db77a1 Huang Rui 2021-12-24 1337 {
3666062b87ec8b Greg Kroah-Hartman 2023-03-13 1338 struct device *dev_root;
ec437d71db77a1 Huang Rui 2021-12-24 1339 int ret;
ec437d71db77a1 Huang Rui 2021-12-24 1340
ec437d71db77a1 Huang Rui 2021-12-24 1341 if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
ec437d71db77a1 Huang Rui 2021-12-24 1342 return -ENODEV;
202e683df37cdf Perry Yuan 2022-11-17 1343 /*
202e683df37cdf Perry Yuan 2022-11-17 1344 * by default the pstate driver is disabled to load
202e683df37cdf Perry Yuan 2022-11-17 1345 * enable the amd_pstate passive mode driver explicitly
36c5014e546096 Wyes Karny 2023-01-31 1346 * with amd_pstate=passive or other modes in kernel command line
202e683df37cdf Perry Yuan 2022-11-17 1347 */
36c5014e546096 Wyes Karny 2023-01-31 1348 if (cppc_state == AMD_PSTATE_DISABLE) {
7af78020e28a53 Kai-Heng Feng 2023-02-23 1349 pr_info("driver load is disabled, boot with specific mode to enable this\n");
202e683df37cdf Perry Yuan 2022-11-17 1350 return -ENODEV;
202e683df37cdf Perry Yuan 2022-11-17 1351 }
ec437d71db77a1 Huang Rui 2021-12-24 1352
ec437d71db77a1 Huang Rui 2021-12-24 1353 if (!acpi_cpc_valid()) {
a2a9d1850060e5 Perry Yuan 2022-08-15 1354 pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n");
ec437d71db77a1 Huang Rui 2021-12-24 1355 return -ENODEV;
ec437d71db77a1 Huang Rui 2021-12-24 1356 }
ec437d71db77a1 Huang Rui 2021-12-24 1357
ec437d71db77a1 Huang Rui 2021-12-24 1358 /* don't keep reloading if cpufreq_driver exists */
ec437d71db77a1 Huang Rui 2021-12-24 1359 if (cpufreq_get_current_driver())
ec437d71db77a1 Huang Rui 2021-12-24 1360 return -EEXIST;
ec437d71db77a1 Huang Rui 2021-12-24 1361
ec437d71db77a1 Huang Rui 2021-12-24 1362 /* capability check */
e059c184da47e9 Huang Rui 2021-12-24 1363 if (boot_cpu_has(X86_FEATURE_CPPC)) {
e059c184da47e9 Huang Rui 2021-12-24 1364 pr_debug("AMD CPPC MSR based functionality is supported\n");
2dd6d0ebf74049 Wyes Karny 2023-03-07 1365 if (cppc_state != AMD_PSTATE_ACTIVE)
ffa5096a7c3386 Perry Yuan 2023-01-31 1366 current_pstate_driver->adjust_perf = amd_pstate_adjust_perf;
202e683df37cdf Perry Yuan 2022-11-17 1367 } else {
202e683df37cdf Perry Yuan 2022-11-17 1368 pr_debug("AMD CPPC shared memory based functionality is supported\n");
e059c184da47e9 Huang Rui 2021-12-24 1369 static_call_update(amd_pstate_enable, cppc_enable);
e059c184da47e9 Huang Rui 2021-12-24 1370 static_call_update(amd_pstate_init_perf, cppc_init_perf);
e059c184da47e9 Huang Rui 2021-12-24 1371 static_call_update(amd_pstate_update_perf, cppc_update_perf);
ec437d71db77a1 Huang Rui 2021-12-24 1372 }
ec437d71db77a1 Huang Rui 2021-12-24 1373
ec437d71db77a1 Huang Rui 2021-12-24 @1374 if (ret) {
ffa5096a7c3386 Perry Yuan 2023-01-31 1375 pr_err("failed to enable with return %d\n", ret);
ec437d71db77a1 Huang Rui 2021-12-24 1376 return ret;
ec437d71db77a1 Huang Rui 2021-12-24 1377 }
ec437d71db77a1 Huang Rui 2021-12-24 1378
ffa5096a7c3386 Perry Yuan 2023-01-31 1379 ret = cpufreq_register_driver(current_pstate_driver);
ec437d71db77a1 Huang Rui 2021-12-24 1380 if (ret)
ffa5096a7c3386 Perry Yuan 2023-01-31 1381 pr_err("failed to register with return %d\n", ret);
ec437d71db77a1 Huang Rui 2021-12-24 1382
3666062b87ec8b Greg Kroah-Hartman 2023-03-13 1383 dev_root = bus_get_dev_root(&cpu_subsys);
3666062b87ec8b Greg Kroah-Hartman 2023-03-13 1384 if (dev_root) {
3666062b87ec8b Greg Kroah-Hartman 2023-03-13 1385 ret = sysfs_create_group(&dev_root->kobj, &amd_pstate_global_attr_group);
3666062b87ec8b Greg Kroah-Hartman 2023-03-13 1386 put_device(dev_root);
abd61c08ef349a Perry Yuan 2023-01-31 1387 if (ret) {
abd61c08ef349a Perry Yuan 2023-01-31 1388 pr_err("sysfs attribute export failed with error %d.\n", ret);
abd61c08ef349a Perry Yuan 2023-01-31 1389 goto global_attr_free;
abd61c08ef349a Perry Yuan 2023-01-31 1390 }
3666062b87ec8b Greg Kroah-Hartman 2023-03-13 1391 }
abd61c08ef349a Perry Yuan 2023-01-31 1392
abd61c08ef349a Perry Yuan 2023-01-31 1393 return ret;
abd61c08ef349a Perry Yuan 2023-01-31 1394
abd61c08ef349a Perry Yuan 2023-01-31 1395 global_attr_free:
abd61c08ef349a Perry Yuan 2023-01-31 1396 cpufreq_unregister_driver(current_pstate_driver);
ec437d71db77a1 Huang Rui 2021-12-24 1397 return ret;
ec437d71db77a1 Huang Rui 2021-12-24 1398 }
456ca88d8a5258 Perry Yuan 2022-11-17 1399 device_initcall(amd_pstate_init);
ec437d71db77a1 Huang Rui 2021-12-24 1400
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
View attachment "config" of type "text/plain" (206836 bytes)
Powered by blists - more mailing lists