linux-kernel - Re: [PATCH mm-nonmm-unstable v2 1/2] squashfs: fix page update race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a5088a8-b5dc-472d-4f43-29d68e3cde16@squashfs.org.uk>
Date:   Fri, 26 May 2023 18:59:00 +0100
From:   Phillip Lougher <phillip@...ashfs.org.uk>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     hch@....de, linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH mm-nonmm-unstable v2 1/2] squashfs: fix page update race


On 26/05/2023 14:57, Vincent Whitchurch wrote:
> We only put the page into the cache after we've read it, so the
> PageUptodate() check should not be necessary.  In fact, it's actively
> harmful since the check could fail (since we used find_get_page() and
> not find_lock_page()) and we could end up submitting a page for I/O
> after it has been read and while it's actively being used, which could
> lead to corruption depending on what the block driver does with it.
>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>


Reviewed-by: Phillip Lougher <phillip@...ashfs.org.uk>