[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230527040905.stmnoshkdqgiaex6@ripper>
Date: Fri, 26 May 2023 21:09:05 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Rudraksha Gupta <guptarud@...il.com>
Cc: Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, david@...t.cz,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi
On Wed, May 24, 2023 at 07:04:54PM -0400, Rudraksha Gupta wrote:
Thank you for your patches Rudraksha!
Please use:
git log --oneline -- arch/arm/boot/dts/qcom-smm8960.dtsi
And look at how other patches to this file has prefixed their subject
line. Then please follow this in your patches (it differs between
patches...).
> Allows msm8960 DTS files to reference the sleep_clk node.
>
Please make the purpose clear in your commit message. Specifically,
which part of msm8960 dts needs to reference the sleep clock?
Please also include a cover letter (git format-patch --cover-letter)
when you send a series of patches.
Regards,
Bjorn
> Signed-off-by: Rudraksha Gupta <guptarud@...il.com>
> ---
> arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index 2a668cd535cc..a4d8dd2d24a6 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -71,7 +71,7 @@ pxo_board: pxo_board {
> clock-output-names = "pxo_board";
> };
>
> - sleep_clk {
> + sleep_clk: sleep_clk {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <32768>;
> --
> 2.34.1
>
Powered by blists - more mailing lists