linux-kernel - Re: [PATCH] omap_ssi_port.c: Drop error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230527165419.a36qup5bsjrthtsb@mercury.elektranox.org>
Date:   Sat, 27 May 2023 18:54:19 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Osama Muhammad <osmtendev@...il.com>
Cc:     jinpu.wang@...os.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] omap_ssi_port.c: Drop error checking for
 debugfs_create_dir

Hi,

On Thu, May 25, 2023 at 08:38:37PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in spi-dw-core.c in
> omap_ssi_port.c. The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
> 
> Signed-off-by: Osama Muhammad <osmtendev@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/controllers/omap_ssi_port.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
> index 7ad41599baa5..8feb91d256fd 100644
> --- a/drivers/hsi/controllers/omap_ssi_port.c
> +++ b/drivers/hsi/controllers/omap_ssi_port.c
> @@ -151,23 +151,20 @@ static int ssi_div_set(void *data, u64 val)
>  
>  DEFINE_DEBUGFS_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
>  
> -static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
> +static void ssi_debug_add_port(struct omap_ssi_port *omap_port,
>  				     struct dentry *dir)
>  {
>  	struct hsi_port *port = to_hsi_port(omap_port->dev);
>  
>  	dir = debugfs_create_dir(dev_name(omap_port->dev), dir);
> -	if (IS_ERR(dir))
> -		return -ENOMEM;
> +
>  	omap_port->dir = dir;
>  	debugfs_create_file("regs", S_IRUGO, dir, port, &ssi_port_regs_fops);
>  	dir = debugfs_create_dir("sst", dir);
> -	if (IS_ERR(dir))
> -		return -ENOMEM;
> +
>  	debugfs_create_file_unsafe("divisor", 0644, dir, port,
>  				   &ssi_sst_div_fops);
>  
> -	return 0;
>  }
>  #endif
>  
> @@ -1217,11 +1214,8 @@ static int ssi_port_probe(struct platform_device *pd)
>  	pm_runtime_enable(omap_port->pdev);
>  
>  #ifdef CONFIG_DEBUG_FS
> -	err = ssi_debug_add_port(omap_port, omap_ssi->dir);
> -	if (err < 0) {
> -		pm_runtime_disable(omap_port->pdev);
> -		goto error;
> -	}
> +	 ssi_debug_add_port(omap_port, omap_ssi->dir);
> +
>  #endif
>  
>  	hsi_add_clients_from_dt(port, np);
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)