linux-kernel - Re: [PATCH v3 0/2] Fixes from evsel__group_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHNU2ULCyO/H6uWA@kernel.org>
Date:   Sun, 28 May 2023 10:19:21 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Sandipan Das <sandipan.das@....com>,
        James Clark <james.clark@....com>,
        Dmitrii Dolgov <9erthalion6@...il.com>,
        Changbin Du <changbin.du@...wei.com>,
        Rob Herring <robh@...nel.org>,
        Xing Zhengjun <zhengjun.xing@...ux.intel.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Fixes from evsel__group_pmu_name asan error

Em Fri, May 26, 2023 at 12:44:40PM -0700, Ian Rogers escreveu:
> evsel__group_pmu_name triggered an asan error as a list_head was cast
> to an evsel, when it was the head, and the accessed as if it were a
> full evsel. Further investigation showed problematic list iteration
> for evsel__group_pmu_name whilst the list was being sorted so switch
> to pre-computation.
> 
> v3: Rebase on perf-tools-next (branch getting ready for 6.5) rather
>     than perf-tools (fixes for 6.4).
> v2: Address review comments/feedback from Adrian Hunter
>     <adrian.hunter@...el.com>.

Thanks, applied.

- Arnaldo

 
> Ian Rogers (2):
>   perf evsel: evsel__group_pmu_name fixes
>   perf evsel: for_each_group fixes
> 
>  tools/perf/util/evsel.c         | 31 ++++-----------
>  tools/perf/util/evsel.h         | 26 +++++++-----
>  tools/perf/util/evsel_fprintf.c |  1 +
>  tools/perf/util/parse-events.c  | 70 +++++++++++++++++++++++++++------
>  4 files changed, 84 insertions(+), 44 deletions(-)
> 
> -- 
> 2.41.0.rc0.172.g3f132b7071-goog
> 

-- 

- Arnaldo