linux-kernel - Re: [PATCH -next v2] memblock: unify memblock dump and debugfs show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43226e0e-94c4-d74f-d1c6-82fe954fa4a0@huawei.com>
Date:   Mon, 29 May 2023 09:12:02 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Mike Rapoport <rppt@...nel.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <tsahu@...ux.ibm.com>,
        <anshuman.khandual@....com>, <ssawgyw@...il.com>
Subject: Re: [PATCH -next v2] memblock: unify memblock dump and debugfs show



On 2023/5/27 18:32, Mike Rapoport wrote:
> Hi Kefeng,
> 
> On Fri, May 26, 2023 at 08:05:05PM +0800, Kefeng Wang wrote:
>> There are two interfaces to show the memblock information, memblock_dump_all()
>> and /sys/kernel/debug/memblock/, but the content is displayed separately,
>> let's unify them in case of more different changes over time.
>   
> I don't see much value in this unifications, especially as it must change
> the format of one of the dumps. Although these are not ABIs, keeping the
> existing formats seems more important to me that having a single dump
> function.

As the debugfs show is similar to memblock_dump, but not exactly the
same, eg,the node info and flag(with/without name), we may want to
support flagname in memblock_dump, also avoid more different changes
in the future. but keep single dump function is fine since they are
not complicated:)