linux-kernel - Re: [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca146ce1-d3d3-e5eb-ac44-3afaec8ca6cc@axis.com>
Date:   Mon, 29 May 2023 09:41:12 +0200
From:   Astrid Rost <astridr@...s.com>
To:     <andy.shevchenko@...il.com>, Astrid Rost <astrid.rost@...s.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...s.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Mathieu Othacehe <m.othacehe@...il.com>
Subject: Re: [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq
 vcnl4040/4200

Hello Andy,

Thanks for reviewing.
I can change this. But this is how it gets formatted by .clang-format.

Astrid

On 5/29/23 00:45, andy.shevchenko@...il.com wrote:
> Mon, May 22, 2023 at 04:26:18PM +0200, Astrid Rost kirjoitti:
>> Add support to configure ambient light sensor interrupts and threshold
>> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
>> will be pushed to the event interface.
> 
> ...
> 
>> +		case IIO_EV_DIR_RISING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_ALS_THDH_LM, val);
> 
> Strange indentation.
> 
>> +			break;
>> +		case IIO_EV_DIR_FALLING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_ALS_THDL_LM, val);
> 
> Same.
> 
>> +			break;
> 
> ...
> 
>> +	case IIO_PROXIMITY:
>> +		switch (dir) {
>> +		case IIO_EV_DIR_RISING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_PS_THDH_LM, val);
> 
> Same.
> 
>> +			break;
>> +		case IIO_EV_DIR_FALLING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_PS_THDL_LM, val);
> 
> Same.
> 
>> +			break;
>